[Improve cc payments identity checks
Adrian Georgescu <ag@ag-projects.com>**20100320122410] hunk ./library/sip_settings.php 1834
+		$this->showIdentityProof();
+
hunk ./library/sip_settings.php 1864
-		if ($_FILES['tmpfile']['tmp_name'] && $_REQUEST['name'] && is_numeric($_REQUEST['last_digits'])) {
+		if ($_REQUEST['task'] == 'upload') {
+            if (!$_FILES['tmpfile']['tmp_name']) {
+                print "<font color=red>";
+                printf (_("Error: Please specify a file"));
+                print "</font>";
+
+            } else if (!$_REQUEST['name']) {
+                print "<font color=red>";
+                printf (_("Error: Please enter the name printed on the Credit Card"));
+                print "</font>";
+
+            } else if (!preg_match("/^\d{4}$/",$_REQUEST['last_digits'])) {
+                print "<font color=red>";
+                printf (_("Error: Last digits must be numeric"));
+                print "</font>";
+
+            } else if (!preg_match("/^\+[1-9][0-9]{7,14}$/",$_REQUEST['mobile_number'])) {
+
+                print "<font color=red>";
+                printf (_("Error: Mobile Number must be in international format starting with +"));
+                print "</font>";
+
+            } else if ($_FILES['tmpfile']['size']['size'] > $max_file_size) {
+                print "<font color=red>";
+                printf (_("Error: Maximum file size is %s"),$max_file_size);
+                print "</font>";
+
+            } else {
hunk ./library/sip_settings.php 1893
-            if ($_FILES['tmpfile']['size']['size'] < $max_file_size) {
-    
hunk ./library/sip_settings.php 1907
-                `last_digits`
+                `last_digits`,
+                `mobile_number`
hunk ./library/sip_settings.php 1919
+                '%s',
hunk ./library/sip_settings.php 1929
-                addslashes($_REQUEST['last_digits'])
+                addslashes($_REQUEST['last_digits']),
+                addslashes($_REQUEST['mobile_number'])
hunk ./library/sip_settings.php 1964
-
-            } else {
-                print "<font color=red>";
-                printf (_("Error: Maximum file size is %s"),$max_file_size);
-                print "</font>";
hunk ./library/sip_settings.php 2004
-            print "<p>";
-            print _("Credit Card payments will be activated after your identity is verified. ");
+	        if (!in_array("payments",$this->groups)) {
+                print "<p>";
+                print _("Credit Card payments will be activated after your identity is verified. ");
+            }
hunk ./library/sip_settings.php 2013
-            printf ("<tr bgcolor=lightgrey><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td>",
+            printf ("<tr bgcolor=lightgrey><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td><td>%s</td>",
hunk ./library/sip_settings.php 2019
-            _("Last digits")
+            _("Last digits"),
+            _("Mobile Number")
hunk ./library/sip_settings.php 2035
-            printf ("<tr> <td>%s</td><td><a href=%s>%s</a></td> <td>%s</td> <td>%s KB</td> <td>%s</td><td align=right>%s</td>",
+            printf ("<tr> <td>%s</td><td><a href=%s>%s</a></td> <td>%s</td> <td>%s KB</td> <td>%s</td><td align=right>%s</td><td align=right>%s</td>",
hunk ./library/sip_settings.php 2042
-            $this->db->f('last_digits')
+            $this->db->f('last_digits'),
+            $this->db->f('mobile_number')
hunk ./library/sip_settings.php 2095
-            printf ("<input type=text size=20 name='name' value='%s'>",$_REQUEST['name']);
+            printf ("<input type=text size=35 name='name' value='%s'>",$_REQUEST['name']);
hunk ./library/sip_settings.php 2114
+
+            print "
+            <tr class=even>
+            <td>";
+            print _("Mobile Number");
+            print "
+            </td>
+            <td colspan=2>
+            ";
+            printf("<input type=text size=15 name='mobile_number' value='%s'> %s",$_REQUEST['mobile_number'],_("International format starting with +"));
hunk ./library/sip_settings.php 2125
+            print "
+            </td>
+            </tr>
+            ";
+
hunk ./library/sip_settings.php 3599
+        if ($mobile_number && !preg_match("/^\+/",$mobile_number)) {
+            $mobile_number='+'.$mobile_number;
+        }
+
hunk ./library/sip_settings.php 4759
-                if ($dial_suffix > 0) {
-                    printf (_("Prefix to auto-complete short numbers"),$dial_suffix);
-                }
hunk ./library/sip_settings.php 4760
+            printf (_("Prefix to auto-complete short numbers"),$dial_suffix);
hunk ./library/sip_settings.php 4770
-    	if ($this->SOAPversion <= 1) return;
-        if (!in_array("free-pstn",$this->groups)) return;
-
hunk ./library/sip_settings.php 4777
-            <input type=text size=15 maxsize=64 name=mobile_number value='%s'>
+            <input type=text size=15 maxsize=64 name=mobile_number value='%s'> %s
hunk ./library/sip_settings.php 4780
-        ",$this->Preferences['mobile_number']);
-
+        ",$this->Preferences['mobile_number'],_("International format starting with +"));
hunk ./setup/mysql/alter_tables.mysql 667
+  `mobile_number` varchar(15) NOT NULL,
hunk ./setup/mysql/create_tables.mysql 654
+  `mobile_number` varchar(15) NOT NULL,